Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Dbex/101195 toggle cleanup (BRD only) #20666

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

WIP: Dbex/101195 toggle cleanup (BRD only) #20666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
73e08ac
Update BRD and Staging BRD providers to run without toggles; remove e…
mchae-nava Feb 6, 2025
d93587c
Remove BRD EVSS services
mchae-nava Feb 6, 2025
7977af0
Remove reference to EVSS BRD service
mchae-nava Feb 6, 2025
d4dedf1
Remove discrepancies controller and spec
mchae-nava Feb 6, 2025
5c1881a
Remove discrepancies route and codeowners
mchae-nava Feb 6, 2025
a596c93
Linting and codeowners update
mchae-nava Feb 6, 2025
e674904
Merge branch 'master' into dbex/101195-toggle-cleanup-brd-only
mchae-nava Feb 6, 2025
e37f411
Merge branch 'master' into dbex/101195-toggle-cleanup-brd-only
mchae-nava Feb 6, 2025
38708dc
Merge branch 'dbex/101195-toggle-cleanup-brd-only' of https://github.…
mchae-nava Feb 6, 2025
1ada1d2
Remove missed BRD service reference
mchae-nava Feb 7, 2025
1339f14
Update swagger spec cassettes for separation_locations
mchae-nava Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ app/controllers/v0/profile @department-of-veterans-affairs/vfs-authenticated-exp
app/controllers/v0/profile/contacts_controller.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/controllers/v0/profile/vet_verification_statuses_controller.rb @department-of-veterans-affairs/va-iir @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/controllers/v0/rated_disabilities_controller.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/controllers/v0/rated_disabilities_discrepancies_controller.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/controllers/v0/search_click_tracking_controller.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/controllers/v0/search_controller.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/controllers/v0/search_typeahead_controller.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
Expand Down Expand Up @@ -912,7 +911,6 @@ lib/evss/reference_data @department-of-veterans-affairs/va-api-engineers @depart
lib/evss/reference_data/configuration.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
lib/evss/reference_data/intake_sites_response.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
lib/evss/reference_data/response_strategy.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
lib/evss/reference_data/service.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
lib/evss/response.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
lib/evss/service_exception.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
lib/evss/service.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
Expand Down Expand Up @@ -1159,7 +1157,6 @@ spec/controllers/v0/preneeds @department-of-veterans-affairs/mbs-core-team @depa
spec/controllers/v0/profile @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/controllers/v0/profile/contacts_controller_spec.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/controllers/v0/rated_disabilities_controller_spec.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/controllers/v0/rated_disabilities_discrepancies_controller_spec.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/controllers/v0/sign_in_controller_spec.rb @department-of-veterans-affairs/octo-identity
spec/controllers/v0/terms_of_use_agreements_controller_spec.rb @department-of-veterans-affairs/octo-identity
spec/controllers/v0/upload_supporting_evidences_controller_spec.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
Expand Down Expand Up @@ -1482,7 +1479,6 @@ spec/lib/evss/pciu_address/response_strategy_spec.rb @department-of-veterans-aff
spec/lib/evss/ppiu @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/lib/evss/reference_data @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/lib/evss/reference_data/configuration_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/lib/evss/reference_data/service_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/lib/evss/service_exception_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/lib/evss/service_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/lib/evss/vso_search @department-of-veterans-affairs/octo-identity
Expand Down
9 changes: 5 additions & 4 deletions app/controllers/v0/disability_compensation_forms_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
require 'evss/disability_compensation_auth_headers'
require 'evss/disability_compensation_form/form4142'
require 'evss/disability_compensation_form/service'
require 'evss/reference_data/service'
require 'evss/reference_data/response_strategy'
require 'disability_compensation/factories/api_provider_factory'

Expand Down Expand Up @@ -35,13 +34,15 @@ def separation_locations
:all_users,
:get_separation_locations
) do
provider = Flipper.enabled?(:disability_compensation_staging_lighthouse_brd) ? :lighthouse_staging : nil
# A separate provider is needed in order to interact with LH Staging and test BRD e2e properly
# We use DD_ENV here as RAILS_ENV is set to 'production' in staging
provider = ENV['DD_ENV'] == 'eks-staging' ? :lighthouse_staging : :lighthouse
api_provider = ApiProviderFactory.call(
type: ApiProviderFactory::FACTORIES[:brd],
provider:,
provider: provider,
options: {},
current_user: @current_user,
feature_toggle: ApiProviderFactory::FEATURE_TOGGLE_BRD
feature_toggle: nil
)
api_provider.get_separation_locations
end
Expand Down
88 changes: 0 additions & 88 deletions app/controllers/v0/rated_disabilities_discrepancies_controller.rb
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions config/features.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@ features:
caregiver_retry_form_validation:
actor_type: user
description: Enables 1010CG to retry schema validation
disability_compensation_staging_lighthouse_brd:
actor_type: user
description: Switches to Lighthouse Staging BRD Service. NEVER ENABLE IN PRODUCTION.
document_upload_validation_enabled:
actor_type: user
description: Enables stamped PDF validation on document upload
Expand Down Expand Up @@ -1725,9 +1722,6 @@ features:
disability_compensation_remove_pciu:
actor_type: user
description: If enabled, VA Profile is used to populate contact information- without PCIU calls (status quo)
disability_compensation_lighthouse_brd:
actor_type: user
description: If enabled uses the lighthouse Benefits Reference Data service
disability_compensation_lighthouse_generate_pdf:
actor_type: user
description: If enabled uses the lighthouse Benefits Claims service to generate a 526 pdf
Expand Down
1 change: 0 additions & 1 deletion config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@
resources :evss_benefits_claims, only: %i[index show] unless Settings.vsp_environment == 'production'

resource :rated_disabilities, only: %i[show]
resource :rated_disabilities_discrepancies, only: %i[show]

namespace :virtual_agent do
get 'claims', to: 'virtual_agent_claim_status#index'
Expand Down
3 changes: 0 additions & 3 deletions lib/disability_compensation/factories/api_provider_factory.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
require 'disability_compensation/providers/claims_service/evss_claims_service_provider'
require 'disability_compensation/providers/claims_service/lighthouse_claims_service_provider'
require 'disability_compensation/providers/brd/brd_provider'
require 'disability_compensation/providers/brd/evss_brd_provider'
require 'disability_compensation/providers/brd/lighthouse_brd_provider'
require 'disability_compensation/providers/brd/lighthouse_staging_brd_provider'
require 'disability_compensation/providers/generate_pdf/generate_pdf_provider'
Expand Down Expand Up @@ -164,8 +163,6 @@ def claims_service_provider

def brd_service_provider
case api_provider
when API_PROVIDER[:evss]
EvssBRDProvider.new(@current_user)
when API_PROVIDER[:lighthouse]
LighthouseBRDProvider.new(@current_user)
when API_PROVIDER[:lighthouse_staging]
Expand Down
16 changes: 0 additions & 16 deletions lib/disability_compensation/providers/brd/evss_brd_provider.rb
View file
Open in desktop

This file was deleted.

46 changes: 0 additions & 46 deletions lib/evss/reference_data/service.rb
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion modules/claims_api/app/controllers/claims_api/v1/forms/disability_compensation_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
require 'evss/disability_compensation_form/dvp/service'
require 'evss/disability_compensation_form/service_exception'
require 'evss/error_middleware'
require 'evss/reference_data/service'
require 'common/exceptions'
require 'jsonapi/parser'
require 'evss_service/base' # docker container
Expand Down
38 changes: 2 additions & 36 deletions spec/controllers/v0/disability_compensation_forms_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,37 +14,9 @@
end

describe '#separation_locations' do
context 'evss' do
before do
Flipper.disable('disability_compensation_lighthouse_brd')
Flipper.disable('disability_compensation_staging_lighthouse_brd')
end

it 'returns separation locations' do
VCR.use_cassette('evss/reference_data/get_intake_sites') do
get(:separation_locations)
expect(JSON.parse(response.body)['separation_locations'].present?).to be(true)
end
end

it 'uses the cached response on the second request' do
VCR.use_cassette('evss/reference_data/get_intake_sites') do
2.times do
get(:separation_locations)
expect(response).to have_http_status(:ok)
end
end
end
end

context 'lighthouse' do
before do
Flipper.enable('disability_compensation_lighthouse_brd')
Flipper.disable('disability_compensation_staging_lighthouse_brd')
end

after(:all) do
Flipper.disable('disability_compensation_lighthouse_brd')
ENV['DD_ENV'] = 'eks-prod'
end

it 'returns separation locations' do
Expand All @@ -66,13 +38,7 @@

context 'lighthouse staging' do
before do
Flipper.enable('disability_compensation_lighthouse_brd')
Flipper.enable('disability_compensation_staging_lighthouse_brd')
end

after(:all) do
Flipper.disable('disability_compensation_lighthouse_brd')
Flipper.disable('disability_compensation_staging_lighthouse_brd')
ENV['DD_ENV'] = 'eks-staging'
end

it 'returns separation locations' do
Expand Down
Loading
Loading