Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10-10EZ] Remove SIGI #20678

Merged
merged 3 commits into from
Feb 11, 2025
+4 −174
Merged

[10-10EZ] Remove SIGI #20678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b91608d
remove sigi
coope93 Feb 7, 2025
0f19976
Merge branch 'master' into 102218-remove-sigi
coope93 Feb 10, 2025
0c475f3
bump vets-json-schema version
coope93 Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ GIT

GIT
remote: https://github.com/department-of-veterans-affairs/vets-json-schema
revision: 75b0a0dd78b479e230867e89989bf3e8262d850c
revision: bdd9c4e3b6fd786798b3254be7af341add314722
branch: master
specs:
vets_json_schema (24.7.4)
vets_json_schema (24.7.5)
multi_json (~> 1.0)
script_utils (= 0.0.4)

Expand Down
22 changes: 1 addition & 21 deletions lib/hca/enrollment_system.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,6 @@ module EnrollmentSystem
'exposureToOther' => 'Other'
}.freeze

SIGI_CODES = {
'M' => 'M',
'F' => 'F',
'TF' => 'TF',
'TM' => 'TM',
'O' => 'O',
'NA' => 'N',
'NB' => 'B'
}.freeze

SERVICE_BRANCH_CODES = {
'army' => 1,
'air force' => 2,
Expand Down Expand Up @@ -431,14 +421,6 @@ def convert_full_name_alt(full_name)
}
end

def convert_sigi(sigi_genders)
return {} if sigi_genders.blank?

{
'selfIdentifiedGenderIdentity' => SIGI_CODES[sigi_genders]
}
end

def veteran_to_person_info(veteran)
convert_full_name(veteran['veteranFullName']).merge({
'gender' => veteran['gender'],
Expand All @@ -454,9 +436,7 @@ def veteran_to_person_info(veteran)
nullable: true
),
'placeOfBirthState' => convert_birth_state(veteran['stateOfBirth'])
}.merge(ssn_to_ssntext(veteran['veteranSocialSecurityNumber']))).merge(
convert_sigi(veteran['sigiGenders'])
)
}.merge(ssn_to_ssntext(veteran['veteranSocialSecurityNumber'])))
end

def convert_birth_state(birth_state)
Expand Down
4 changes: 1 addition & 3 deletions spec/fixtures/files/forms/healthcare_application_request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
{
"asyncCompatible": true,
"form": "{\"isMedicaidEligible\":true,\"spouseAddress\":{\"street\":\"12345 Elm St\",\"city\":\"Houston\",\"postalCode\":\"77388\",\"country\":\"USA\",\"state\":\"TX\"},\"spousePhone\":\"2122122121\",\"cohabitedLastYear\":true,\"sameAddress\":false,\"medicarePartAEffectiveDate\":\"2000-01-01\",\"medicareClaimNumber\":\"0123456\",\"isEnrolledMedicarePartA\":true,\"isCoveredByHealthInsurance\":true,\"providers\":[{\"insuranceName\":\"Aetna\",\"insurancePolicyHolderName\":\"Indiana Jones\",\"insurancePolicyNumber\":\"32345111\",\"insuranceGroupCode\":\"1233444\"}],\"deductibleMedicalExpenses\":0,\"deductibleFuneralExpenses\":0,\"deductibleEducationExpenses\":0,\"spouseGrossIncome\":20,\"spouseNetIncome\":21,\"spouseOtherIncome\":22,\"veteranGrossIncome\":60000,\"veteranNetIncome\":0,\"veteranOtherIncome\":0,\"spouseFullName\":{\"first\":\"Jane\",\"middle\":\"marie\",\"last\":\"Jones\"},\"spouseDateOfBirth\":\"1977-01-01\",\"dateOfMarriage\":\"2000-01-01\",\"maritalStatus\":\"Married\",\"purpleHeartRecipient\":true,\"isFormerPow\":true,\"postNov111998Combat\":true,\"disabledInLineOfDuty\":true,\"swAsiaCombat\":true,\"vietnamService\":true,\"exposedToRadiation\":true,\"radiumTreatments\":true,\"campLejeune\":true,\"discloseFinancialInformation\":true,\"lastServiceBranch\":\"air force\",\"lastEntryDate\":\"1998-01-01\",\"lastDischargeDate\":\"2004-01-01\",\"dischargeType\":\"honorable\",\"vaCompensationType\":\"lowDisability\",\"isAmericanIndianOrAlaskanNative\":true,\"isAsian\":true,\"isBlackOrAfricanAmerican\":true,\"isSpanishHispanicLatino\":true,\"isNativeHawaiianOrOtherPacificIslander\":true,\"isWhite\":true,\"hasDemographicNoAnswer\":true,\"isEssentialAcaCoverage\":true,\"vaMedicalFacility\":\"520GA\",\"wantsInitialVaContact\":true,\"email\":\"[email protected]\",\"homePhone\":\"3462636183\",\"mobilePhone\":\"3462636184\",\"veteranAddress\":{\"street\":\"321 Elm St\",\"city\":\"Houston\",\"postalCode\":\"77388\",\"country\":\"USA\",\"state\":\"TX\"},\"sigiGenders\":\"M\",\"gender\":\"M\",\"mothersMaidenName\":\"Test\",\"cityOfBirth\":\"Spring\",\"stateOfBirth\":\"TX\",\"veteranFullName\":{\"first\":\"Indiana\",\"last\":\"Jones\"},\"veteranSocialSecurityNumber\":\"234221243\",\"veteranDateOfBirth\":\"1980-01-01\",\"privacyAgreementAccepted\":true,\"dependents\":[{\"fullName\":{\"first\":\"Bob\",\"middle\":\"Joe\",\"last\":\"Jones\"},\"dependentRelation\":\"Son\",\"socialSecurityNumber\":\"343221234\",\"dateOfBirth\":\"2000-02-01\",\"becameDependent\":\"2000-02-01\",\"attendedSchoolLastYear\":true,\"dependentEducationExpenses\":0,\"disabledBefore18\":false,\"cohabitedLastYear\":true,\"grossIncome\":10,\"netIncome\":11,\"otherIncome\":12}],\"veteranHomeAddress\":{\"street\":\"123 Elm St\",\"city\":\"Houston\",\"postalCode\":\"77388\",\"country\":\"USA\",\"state\":\"TX\"}}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was just removing ,\"sigiGenders\":\"M\" from this json. It's on one line so the diff is harder to read.

"form": "{\"isMedicaidEligible\":true,\"spouseAddress\":{\"street\":\"12345 Elm St\",\"city\":\"Houston\",\"postalCode\":\"77388\",\"country\":\"USA\",\"state\":\"TX\"},\"spousePhone\":\"2122122121\",\"cohabitedLastYear\":true,\"sameAddress\":false,\"medicarePartAEffectiveDate\":\"2000-01-01\",\"medicareClaimNumber\":\"0123456\",\"isEnrolledMedicarePartA\":true,\"isCoveredByHealthInsurance\":true,\"providers\":[{\"insuranceName\":\"Aetna\",\"insurancePolicyHolderName\":\"Indiana Jones\",\"insurancePolicyNumber\":\"32345111\",\"insuranceGroupCode\":\"1233444\"}],\"deductibleMedicalExpenses\":0,\"deductibleFuneralExpenses\":0,\"deductibleEducationExpenses\":0,\"spouseGrossIncome\":20,\"spouseNetIncome\":21,\"spouseOtherIncome\":22,\"veteranGrossIncome\":60000,\"veteranNetIncome\":0,\"veteranOtherIncome\":0,\"spouseFullName\":{\"first\":\"Jane\",\"middle\":\"marie\",\"last\":\"Jones\"},\"spouseDateOfBirth\":\"1977-01-01\",\"dateOfMarriage\":\"2000-01-01\",\"maritalStatus\":\"Married\",\"purpleHeartRecipient\":true,\"isFormerPow\":true,\"postNov111998Combat\":true,\"disabledInLineOfDuty\":true,\"swAsiaCombat\":true,\"vietnamService\":true,\"exposedToRadiation\":true,\"radiumTreatments\":true,\"campLejeune\":true,\"discloseFinancialInformation\":true,\"lastServiceBranch\":\"air force\",\"lastEntryDate\":\"1998-01-01\",\"lastDischargeDate\":\"2004-01-01\",\"dischargeType\":\"honorable\",\"vaCompensationType\":\"lowDisability\",\"isAmericanIndianOrAlaskanNative\":true,\"isAsian\":true,\"isBlackOrAfricanAmerican\":true,\"isSpanishHispanicLatino\":true,\"isNativeHawaiianOrOtherPacificIslander\":true,\"isWhite\":true,\"hasDemographicNoAnswer\":true,\"isEssentialAcaCoverage\":true,\"vaMedicalFacility\":\"520GA\",\"wantsInitialVaContact\":true,\"email\":\"[email protected]\",\"homePhone\":\"3462636183\",\"mobilePhone\":\"3462636184\",\"veteranAddress\":{\"street\":\"321 Elm St\",\"city\":\"Houston\",\"postalCode\":\"77388\",\"country\":\"USA\",\"state\":\"TX\"},\"gender\":\"M\",\"mothersMaidenName\":\"Test\",\"cityOfBirth\":\"Spring\",\"stateOfBirth\":\"TX\",\"veteranFullName\":{\"first\":\"Indiana\",\"last\":\"Jones\"},\"veteranSocialSecurityNumber\":\"234221243\",\"veteranDateOfBirth\":\"1980-01-01\",\"privacyAgreementAccepted\":true,\"dependents\":[{\"fullName\":{\"first\":\"Bob\",\"middle\":\"Joe\",\"last\":\"Jones\"},\"dependentRelation\":\"Son\",\"socialSecurityNumber\":\"343221234\",\"dateOfBirth\":\"2000-02-01\",\"becameDependent\":\"2000-02-01\",\"attendedSchoolLastYear\":true,\"dependentEducationExpenses\":0,\"disabledBefore18\":false,\"cohabitedLastYear\":true,\"grossIncome\":10,\"netIncome\":11,\"otherIncome\":12}],\"veteranHomeAddress\":{\"street\":\"123 Elm St\",\"city\":\"Houston\",\"postalCode\":\"77388\",\"country\":\"USA\",\"state\":\"TX\"}}"
}


58 changes: 0 additions & 58 deletions spec/fixtures/hca/sigi.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion spec/fixtures/pdf_fill/10-10EZ/simple.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"country": "USA",
"state": "TX"
},
"sigiGenders": "M",
"gender": "M",
"mothersMaidenName": "Test",
"cityOfBirth": "Spring",
Expand Down
12 changes: 0 additions & 12 deletions spec/lib/hca/service_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,18 +131,6 @@
end
end

context 'submitting sigi field' do
it 'works', run_at: 'Tue, 01 Nov 2022 15:07:20 GMT' do
VCR.use_cassette(
'hca/sigi',
VCR::MATCH_EVERYTHING.merge(erb: true)
) do
result = HCA::Service.new.submit_form(get_fixture('hca/sigi'))
expect(result[:success]).to be(true)
end
end
end

context 'submitting tera questions' do
it 'works', run_at: 'Fri, 23 Feb 2024 19:47:28 GMT' do
VCR.use_cassette(
Expand Down
77 changes: 0 additions & 77 deletions spec/support/vcr_cassettes/hca/sigi.yml
View file
Open in desktop

This file was deleted.

Loading