Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10-10EZ] Remove SIGI #20678

Merged
merged 3 commits into from
Feb 11, 2025
Merged

[10-10EZ] Remove SIGI #20678

merged 3 commits into from
Feb 11, 2025
+4 −174

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Feb 7, 2025 •
edited
Loading

Summary

  • This work is behind a feature toggle (flipper): NO, but vets-website does not pass the sigi field
  • Since the Self-Identifying Gender Identity work has never been approved for launch, and does not seem to be a priority for the VA at this time, we have been asked to permanently remove the code from the 10-10EZ. This PR removes it from this repo for the 10-10EZ.
  • Updating the vets_json_schema gem to match the updated schema with the SIGI key removed
  • 1010 Health Apps

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

No UI changes

What areas of the site does it impact?

10-10EZ

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to 102218-remove-sigi/main/main February 7, 2025 16:09 Inactive
coope93
coope93 commented Feb 10, 2025
View reviewed changes
spec/fixtures/files/forms/healthcare_application_request.json
@@ -1,6 +1,4 @@
{
"asyncCompatible": true,
"form": "{\"isMedicaidEligible\":true,\"spouseAddress\":{\"street\":\"12345 Elm St\",\"city\":\"Houston\",\"postalCode\":\"77388\",\"country\":\"USA\",\"state\":\"TX\"},\"spousePhone\":\"2122122121\",\"cohabitedLastYear\":true,\"sameAddress\":false,\"medicarePartAEffectiveDate\":\"2000-01-01\",\"medicareClaimNumber\":\"0123456\",\"isEnrolledMedicarePartA\":true,\"isCoveredByHealthInsurance\":true,\"providers\":[{\"insuranceName\":\"Aetna\",\"insurancePolicyHolderName\":\"Indiana Jones\",\"insurancePolicyNumber\":\"32345111\",\"insuranceGroupCode\":\"1233444\"}],\"deductibleMedicalExpenses\":0,\"deductibleFuneralExpenses\":0,\"deductibleEducationExpenses\":0,\"spouseGrossIncome\":20,\"spouseNetIncome\":21,\"spouseOtherIncome\":22,\"veteranGrossIncome\":60000,\"veteranNetIncome\":0,\"veteranOtherIncome\":0,\"spouseFullName\":{\"first\":\"Jane\",\"middle\":\"marie\",\"last\":\"Jones\"},\"spouseDateOfBirth\":\"1977-01-01\",\"dateOfMarriage\":\"2000-01-01\",\"maritalStatus\":\"Married\",\"purpleHeartRecipient\":true,\"isFormerPow\":true,\"postNov111998Combat\":true,\"disabledInLineOfDuty\":true,\"swAsiaCombat\":true,\"vietnamService\":true,\"exposedToRadiation\":true,\"radiumTreatments\":true,\"campLejeune\":true,\"discloseFinancialInformation\":true,\"lastServiceBranch\":\"air force\",\"lastEntryDate\":\"1998-01-01\",\"lastDischargeDate\":\"2004-01-01\",\"dischargeType\":\"honorable\",\"vaCompensationType\":\"lowDisability\",\"isAmericanIndianOrAlaskanNative\":true,\"isAsian\":true,\"isBlackOrAfricanAmerican\":true,\"isSpanishHispanicLatino\":true,\"isNativeHawaiianOrOtherPacificIslander\":true,\"isWhite\":true,\"hasDemographicNoAnswer\":true,\"isEssentialAcaCoverage\":true,\"vaMedicalFacility\":\"520GA\",\"wantsInitialVaContact\":true,\"email\":\"[email protected]\",\"homePhone\":\"3462636183\",\"mobilePhone\":\"3462636184\",\"veteranAddress\":{\"street\":\"321 Elm St\",\"city\":\"Houston\",\"postalCode\":\"77388\",\"country\":\"USA\",\"state\":\"TX\"},\"sigiGenders\":\"M\",\"gender\":\"M\",\"mothersMaidenName\":\"Test\",\"cityOfBirth\":\"Spring\",\"stateOfBirth\":\"TX\",\"veteranFullName\":{\"first\":\"Indiana\",\"last\":\"Jones\"},\"veteranSocialSecurityNumber\":\"234221243\",\"veteranDateOfBirth\":\"1980-01-01\",\"privacyAgreementAccepted\":true,\"dependents\":[{\"fullName\":{\"first\":\"Bob\",\"middle\":\"Joe\",\"last\":\"Jones\"},\"dependentRelation\":\"Son\",\"socialSecurityNumber\":\"343221234\",\"dateOfBirth\":\"2000-02-01\",\"becameDependent\":\"2000-02-01\",\"attendedSchoolLastYear\":true,\"dependentEducationExpenses\":0,\"disabledBefore18\":false,\"cohabitedLastYear\":true,\"grossIncome\":10,\"netIncome\":11,\"otherIncome\":12}],\"veteranHomeAddress\":{\"street\":\"123 Elm St\",\"city\":\"Houston\",\"postalCode\":\"77388\",\"country\":\"USA\",\"state\":\"TX\"}}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was just removing ,\"sigiGenders\":\"M\" from this json. It's on one line so the diff is harder to read.

@coope93 coope93 mentioned this pull request Feb 10, 2025
Merged
@coope93 coope93 changed the title remove sigi [10-10EZ] Remove SIGI Feb 10, 2025
@coope93 coope93 marked this pull request as ready for review February 10, 2025 16:15
@coope93 coope93 requested review from a team as code owners February 10, 2025 16:15
@va-vfs-bot va-vfs-bot temporarily deployed to 102218-remove-sigi/main/main February 10, 2025 16:16 Inactive
dellerbie
dellerbie previously approved these changes Feb 10, 2025
View reviewed changes
rmtolmach
rmtolmach previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@coope93 coope93 dismissed stale reviews from rmtolmach and dellerbie via 0c475f3 February 11, 2025 14:50
@va-vfs-bot va-vfs-bot temporarily deployed to 102218-remove-sigi/main/main February 11, 2025 14:51 Inactive
@coope93 coope93 self-assigned this Feb 11, 2025
rmtolmach
rmtolmach approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vets_json_schema version matches https://github.com/department-of-veterans-affairs/vets-json-schema/blob/master/package.json#L3

@coope93 coope93 merged commit c7449ef into master Feb 11, 2025
42 checks passed
@coope93 coope93 deleted the 102218-remove-sigi branch February 11, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmtolmach rmtolmach rmtolmach approved these changes

@dellerbie dellerbie Awaiting requested review from dellerbie

@JoshingYou1 JoshingYou1 Awaiting requested review from JoshingYou1

@Mitch-A6 Mitch-A6 Awaiting requested review from Mitch-A6

Assignees

@coope93 coope93

Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coope93 @dellerbie @rmtolmach @va-vfs-bot