Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10-10EZ] Remove SIGI from 10-10EZ #972

Merged
merged 2 commits into from
Feb 11, 2025
Merged

[10-10EZ] Remove SIGI from 10-10EZ #972

merged 2 commits into from
Feb 11, 2025

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Feb 7, 2025

New schema

Since the Self-Identifying Gender Identity work has never been approved for launch, and does not seem to be a priority for the VA at this time, we have been asked to permanently remove the code from the 10-10EZ. This PR removes it from the schema.

Please ensure you have incremented the version in package.json.

Pull Requests to update the schema in related repositories

After you've merged your changes to vets-json-schema you'll need to make PR's to vets-website and vets-api. Please link them here.

@coope93 coope93 changed the title remove sigi for 1010ez [10-10EZ] Remove SIGI from 10-10EZ Feb 10, 2025
@coope93 coope93 marked this pull request as ready for review February 10, 2025 16:10
@coope93 coope93 requested review from a team as code owners February 10, 2025 16:10
@rmtolmach
Copy link
Contributor

@coope93 I see a few more instances in this repo. Should they also be removed? https://github.com/search?q=repo%3Adepartment-of-veterans-affairs%2Fvets-json-schema%20sigi&type=code

@coope93
Copy link
Contributor Author

coope93 commented Feb 10, 2025

@coope93 I see a few more instances in this repo. Should they also be removed? https://github.com/search?q=repo%3Adepartment-of-veterans-affairs%2Fvets-json-schema%20sigi&type=code

@rmtolmach Thanks for looking out! Those are still being used by the EZR form schema, and I was going to let them remove those separately.

Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 gotcha! sounds good.

@coope93 coope93 merged commit bdd9c4e into master Feb 11, 2025
5 checks passed
@coope93 coope93 deleted the 102218-remove-sigi branch February 11, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants