Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mixer] Media Player Components Docs PR2 #4629

Merged
merged 8 commits into from
Feb 9, 2025

Conversation

kahrendt
Copy link
Contributor

@kahrendt kahrendt commented Jan 31, 2025

Description:

This is documentation pull request 2 of 3 for adding new speaker media player components with several other helper components. It is built off #4628

PR2 adds documentation for the mixer speaker component.

Related issue (if applicable): not applicable

Pull request in esphome with YAML changes (if applicable): esphome/esphome#8170

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit a22511f
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/679d0736854a1e00089f0edd
😎 Deploy Preview https://deploy-preview-4629--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 9a05f3c
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/67a9230283ece40008fc5325
😎 Deploy Preview https://deploy-preview-4629--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kahrendt kahrendt marked this pull request as ready for review January 31, 2025 19:01
components/speaker/mixer.rst Outdated Show resolved Hide resolved
components/speaker/mixer.rst Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft February 9, 2025 21:49
@esphome
Copy link

esphome bot commented Feb 9, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jesserockz jesserockz marked this pull request as ready for review February 9, 2025 21:50
@esphome esphome bot requested a review from jesserockz February 9, 2025 21:50
@jesserockz jesserockz enabled auto-merge (squash) February 9, 2025 21:50
@jesserockz jesserockz merged commit 2f2f419 into esphome:next Feb 9, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants