add pyo3-python-tracing-subscriber to auto-approve list
#4527
Conversation
| @@ -15,6 +15,7 @@ jobs: | |||
| startsWith(github.event.issue.title, 'publish: getsentry/json-schema-diff@') || | |||
| startsWith(github.event.issue.title, 'publish: getsentry/ophio@') || | |||
| startsWith(github.event.issue.title, 'publish: getsentry/pdb@') || | |||
| startsWith(github.event.issue.title, 'publish: getsentry/pyo3-python-tracing-subscriber@') || | |||
There was a problem hiding this comment.
please enable branch protection and CI
There was a problem hiding this comment.
@asottile-sentry could you elaborate? there are branch protections and CI on that repo. i am a repo admin so i have bypassed branch protection while getting this set up, but i don't intend to continue doing that. i can see if there was an option that disallows me from bypassing
There was a problem hiding this comment.
hmm I'm not seeing any set up in the settings tab
There was a problem hiding this comment.
ah i used the "rules" tab
There was a problem hiding this comment.
ah nice -- though I think that's not going to work with the release bot unless you add it to the rule bypass?
There was a problem hiding this comment.
getsentry/pyo3-python-tracing-subscriber@3bfc713 looks like it worked. i've added an exception for it in case there is some later step that needs more permission but i can dump it if the version bump was the only thing you were thinking of
There was a problem hiding this comment.
(you'll see in that commit i messed up the version bump script so the release didn't finish haha)
There was a problem hiding this comment.
the commit creation doesn't require rule bypass -- the merger into the final branch does though
There was a problem hiding this comment.
got it. thanks! the release-bot team is excepted now
as title