Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pyo3-python-tracing-subscriber to auto-approve list #4527

Merged
merged 1 commit into from
Oct 29, 2024
Merged

add pyo3-python-tracing-subscriber to auto-approve list #4527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/auto-approve.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
startsWith(github.event.issue.title, 'publish: getsentry/json-schema-diff@') ||
startsWith(github.event.issue.title, 'publish: getsentry/ophio@') ||
startsWith(github.event.issue.title, 'publish: getsentry/pdb@') ||
startsWith(github.event.issue.title, 'publish: getsentry/pyo3-python-tracing-subscriber@') ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please enable branch protection and CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile-sentry could you elaborate? there are branch protections and CI on that repo. i am a repo admin so i have bypassed branch protection while getting this set up, but i don't intend to continue doing that. i can see if there was an option that disallows me from bypassing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I'm not seeing any set up in the settings tab

Screenshot 2024-10-28 at 1 22 47 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-28 at 10 23 56 AM

ah i used the "rules" tab

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice -- though I think that's not going to work with the release bot unless you add it to the rule bypass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getsentry/pyo3-python-tracing-subscriber@3bfc713 looks like it worked. i've added an exception for it in case there is some later step that needs more permission but i can dump it if the version bump was the only thing you were thinking of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(you'll see in that commit i messed up the version bump script so the release didn't finish haha)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit creation doesn't require rule bypass -- the merger into the final branch does though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. thanks! the release-bot team is excepted now

startsWith(github.event.issue.title, 'publish: getsentry/pytest-sentry@') ||
startsWith(github.event.issue.title, 'publish: getsentry/relay/py@') ||
startsWith(github.event.issue.title, 'publish: getsentry/responses@') ||
Expand Down
Loading