-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): Propagate sample_rand to transaction's baggage #4040
Open
szokeasaurusrex
wants to merge
1
commit into
szokeasaurusrex/sample_rand-2
Choose a base branch
from
szokeasaurusrex/sample_rand-3
base: szokeasaurusrex/sample_rand-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(tracing): Propagate sample_rand to transaction's baggage #4040
szokeasaurusrex
wants to merge
1
commit into
szokeasaurusrex/sample_rand-2
from
szokeasaurusrex/sample_rand-3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## szokeasaurusrex/sample_rand-2 #4040 +/- ##
=================================================================
+ Coverage 80.30% 80.36% +0.06%
=================================================================
Files 140 140
Lines 15545 15554 +9
Branches 2635 2637 +2
=================================================================
+ Hits 12483 12500 +17
+ Misses 2225 2210 -15
- Partials 837 844 +7
|
14a70da
to
0a0de06
Compare
92cd6fb
to
bea45b9
Compare
0a0de06
to
21bb038
Compare
bea45b9
to
6363759
Compare
21bb038
to
836d5b1
Compare
154662a
to
af64b16
Compare
836d5b1
to
cbfc36a
Compare
af64b16
to
01334d7
Compare
cbfc36a
to
6f66ce8
Compare
01334d7
to
7ec8e08
Compare
6f66ce8
to
fec92c5
Compare
`continue_trace` now propagates incoming `sample_rand` values to the transaction's baggage. Also, in the case where `sample_rand` is missing from the incoming trace and needs to be backfilled, this change introduces a mechanism for the backfilled value from the scope's propagation context to be propagated to the transaction's baggage. The transaction still does not use the `sample_rand` for making sampling decisions; this PR only enables propagation. A future PR will add support for reading the incoming/backfilled `sample_rand` and for using this value to make sampling decisions. Ref #3998
fec92c5
to
d486a8f
Compare
7ec8e08
to
b400fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue_trace
now propagates incomingsample_rand
values to the transaction's baggage. Also, in the case wheresample_rand
is missing from the incoming trace and needs to be backfilled, this change introduces a mechanism for the backfilled value from the scope's propagation context to be propagated to the transaction's baggage.The transaction still does not use the
sample_rand
for making sampling decisions; this PR only enables propagation. A future PR will add support for reading the incoming/backfilledsample_rand
and for using this value to make sampling decisions.Depends on:
sample_rand
onPropagationContext
#4038Ref #3998
Thank you for contributing to
sentry-python
! Please add tests to validate your changes, and lint your code usingtox -e linters
.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.