Update to BYSETPOS support #449

nehresma · 2018-07-30T20:09:01Z

In August 2016, Nicolas Marlier added BYSETPOS support (#349). This PR updates that PR with a few small changes to run in modern Ruby (use Integer instead of Fixnum) and a more modern rspec.

nehresma · 2018-07-30T20:23:49Z

Hat tip to @NicolasMarlier for doing this.

davidstosik · 2019-01-04T10:21:37Z

I can confirm this works as expected, this is fantastic! 👍

davidstosik

I left comments to see if we can improve the code of this PR.
I'll try implementing them myself and link a diff here a bit later.

davidstosik · 2019-01-04T10:23:43Z

.gitignore

@@ -8,5 +8,8 @@
 /spec/reports/
 /tmp/

+# rubymine
+.idea
+


Is that necessary? It looks like an accidental addition that is not part of this PR.

davidstosik · 2019-01-04T10:26:16Z

lib/ice_cube/time_util.rb

@@ -198,6 +200,36 @@ def self.which_occurrence_in_month(time, wday)
      [nth_occurrence_of_weekday, this_weekday_in_month_count]
    end

+    # Use Activesupport CoreExt functions to manipulate time
+    def self.start_of_month time
+      time.beginning_of_month


Why not reuse the same name?

davidstosik · 2019-01-04T10:26:28Z

lib/ice_cube/time_util.rb

+
+    # Use Activesupport CoreExt functions to manipulate time
+    def self.start_of_year time
+      time.beginning_of_year


Why not reuse the same name?

davidstosik · 2019-01-04T10:28:47Z

lib/ice_cube/time_util.rb

+
+    # Use Activesupport CoreExt functions to manipulate time
+    def self.previous_month time
+      time - 1.month


I think time.last_month exists?

davidstosik · 2019-01-04T10:29:05Z

lib/ice_cube/time_util.rb

+
+    # Use Activesupport CoreExt functions to manipulate time
+    def self.previous_year time
+      time - 1.year


I think time.last_year exists?

davidstosik · 2019-01-04T10:33:54Z

lib/ice_cube/validations/monthly_by_set_pos.rb

+      return by_set_pos([by_set_pos]) if by_set_pos.is_a?(Integer)
+
+      unless by_set_pos.nil? || by_set_pos.is_a?(Array)
+        raise ArgumentError, "Expecting Array or nil value for count, got #{by_set_pos.inspect}"


This validation seems unnecessary as well. by_set_pos is always an Array.

davidstosik · 2019-01-04T10:37:28Z

lib/ice_cube/validations/monthly_by_set_pos.rb

+      end
+      by_set_pos.flatten!
+      by_set_pos.each do |set_pos|
+        unless (set_pos >= -366 && set_pos <= -1) ||


How about (-366..366).include(set_post) && set_pos != 0?

lib/ice_cube/validations/monthly_by_set_pos.rb

davidstosik · 2019-01-04T10:40:49Z

lib/ice_cube/validations/monthly_by_set_pos.rb

+      end
+
+      @by_set_pos = by_set_pos
+      replace_validations_for(:by_set_pos, by_set_pos && [Validation.new(by_set_pos, self)])


If I understand correctly, by_set_pos cannot be nil or false here (it's an Array), in which case by_set_pos && [Validation.new(by_set_pos, self)] is equivalent to its right-side operand, [Validation.new(by_set_pos, self)].

lib/ice_cube/validations/yearly_by_set_pos.rb

nehresma · 2019-01-04T12:32:20Z

Hello @davidstosik, @NicolasMarlier provided this original PR. I simply updated it to work with modern versions of Ruby.

k3rni · 2019-01-04T15:22:09Z

lib/ice_cube/validations/monthly_by_set_pos.rb

+
+
+        new_schedule = IceCube::Schedule.new(TimeUtil.previous_month(step_time)) do |s|
+          s.add_recurrence_rule IceCube::Rule.from_hash(rule.to_hash.reject{|k, v| [:by_set_pos, :count, :until].include? k})


With ActiveSupport, this reject construct simplifies to except(:by_set_pos, :count, :util)

k3rni · 2019-01-04T15:23:07Z

lib/ice_cube/validations/yearly_by_set_pos.rb

+
+
+        new_schedule = IceCube::Schedule.new(TimeUtil.previous_year(step_time)) do |s|
+          s.add_recurrence_rule IceCube::Rule.from_hash(rule.to_hash.reject{|k, v| [:by_set_pos, :count, :until].include? k})


same here, use Hash#except

k3rni · 2019-01-04T15:24:03Z

spec/examples/by_set_pos_spec.rb

+      schedule = IceCube::Schedule.from_ical "RRULE:FREQ=MONTHLY;COUNT=4;BYDAY=WE;BYSETPOS=4"
+      schedule.start_time = Time.new(2015, 5, 28, 12, 0, 0)
+      expect(schedule.occurrences_between(Time.new(2015, 01, 01), Time.new(2017, 01, 01))).to eq([
+                                                                                                     Time.new(2015,6,24,12,0,0),


I'd say just breaking .to onto a newline is good enough

@NicolasMarlier

In August 2016, @NicolasMarlier added BYSETPOS support (ice-cube-ruby#349). Then, in July 2018, @nehresma added a few small changes to run in modern Ruby and a more modern rspec (ice-cube-ruby#449). Then, in January 2019, @davidstosik and @k3rni suggested changes to reduce complexity. This incorporates all the above into a single diff.

dimerman · 2019-03-22T06:14:22Z

@nehresma what's the status of this PR? I'd very much like to use the setpos functionality.

nehresma · 2019-03-22T12:57:47Z

@dimerman It has been merged but I do not believe a new version of the gem has been released. I've pointed my Gemfile to the latest git ref on master for the time being. Hopefully someone will have a few minutes to cut a new gem release at some point so we wont have to point to specific refs.

nehresma · 2019-03-22T13:00:18Z

@dimerman Err, no -- I'm an idiot. I just realized it has NOT been merged. I checked my Gemfile and I'm pointing to the ref with BYSETPOS support out on my fork -- not master on seejohnrun/ice_cube.

Sorry for the confusion. I should have double checked before trusting my memory.

dimerman · 2019-03-23T05:18:26Z

@nehresma no worries - I've been pointing my gemfile to your branch/repo. thanks for that!

However, I found the following case is not working right:

rule_a="FREQ=MONTHLY;COUNT=12;BYDAY=MO,TU,WE,TH,FR;BYSETPOS=-1"
rule_b="FREQ=MONTHLY;COUNT=12;BYDAY=MO,TU,WE,TH,FR;BYMONTHDAY=13,14,15;BYSETPOS=-1"

when I create a IceCube::Schedule and add each rule individually, the occurrences are accurate. But if I create a schedule with both these rules, I get 18 occurrences instead of the expected 24.
I thought you might want to know. 🙌

mattbooks · 2019-03-28T21:19:05Z

What's still holding this back — the PR feedback seems pretty minor? If that gets cleaned up can we get this merged?

mattbooks · 2019-04-01T18:54:24Z

@seejohnrun It seems like several people need this and are using forks to get around it being missing. I'd be more than happy to help clean this up to avoid using a fork myself if it is otherwise merge-able.

ovinix · 2019-04-11T14:26:14Z

lib/ice_cube/validations/monthly_by_set_pos.rb

+
+
+      def build_s(builder)
+        builder.piece(:by_set_pos) << by_set_pos


Hello @nehresma

Looks like this should be improved:

> IceCube::Rule.monthly(2).day(1,2,3,4,5).by_set_pos(2).to_s "Every 2 months on Weekdays [2]"

pacso · 2021-10-21T23:29:21Z

@nehresma / @mattbooks / @ovinix - If you can get this PR cleaned up and resolve the feedback and conflicts with master, I'll give it a proper review.

Naren1997 · 2022-03-06T13:50:14Z

Hello, looks like the gem IS already supporting what BYTSETPOS does but in different ical format. Example: If we want recurring for every 2 months 3rd Wednesday, ical format w.r.t the BYSETPOS is FREQ=MONTHLY;INTERVAL=2;BYDAY=WE;BYSETPOS=3 which is same as FREQ=MONTHLY;INTERVAL=2;BYDAY=3WE, the latter one is already supported by the gem, so not sure why we still wants this PR.

davidstosik · 2022-03-06T22:17:16Z

not sure why we still wants this PR

I don’t use the gem anymore, but you might want to consider that some people use the gem to parse strings produced by another piece of software they don’t have control on, and this would require the whole specification to be supported. 😉

jhubert · 2022-05-13T04:07:53Z

@avit Anything we can do to help get this merged?

dimerman · 2022-05-13T04:10:09Z

@davidstosik what gem do you use instead?

davidstosik · 2022-05-19T20:28:01Z

Nothing. 😬
My need to handle repeating schedules in Ruby has vanished. 🙇🏻‍♂️

A few small updates to Nicolas Marlier's BYSETPOS support added in PR ice-cube-ruby#349

rebased against master -- its been 4 years

nehresma · 2022-12-12T17:33:54Z

It's been over 4 years since I created this PR and over 7 years since Nicolas Marlier's initial commit with this support. I have rebased it against current master and I've applied changes per the feedback received above.

If someone has time to review and merge, that would be most appreciated. BYSETPOS is part of RFC 5545 and it would be great if this gem could finally get support merged in rather than just the "noop" that it currently is (https://github.com/ice-cube-ruby/ice_cube/blob/master/lib/ice_cube/parsers/ical_parser.rb#L77-L78).

lib/ice_cube/validations/monthly_by_set_pos.rb

nehresma · 2022-12-23T20:38:09Z

@jkehres I've fixed the interval use for month and year frequencies with bysetpos. I ran out of time for adding support for the other frequencies yet. I'll add support for those after Christmas.

lib/ice_cube/validations/monthly_by_set_pos.rb

lib/ice_cube/validations/yearly_by_set_pos.rb

lib/ice_cube/validations/monthly_by_set_pos.rb

lib/ice_cube/validations/yearly_by_set_pos.rb

nehresma · 2022-12-27T16:35:26Z

I've pushed bysetpos support for weekly frequencies too. I don't think bysetpos makes sense with frequencies of daily, hourly, minutely, or secondly. RFC 5545 makes no mention of them, and indeed all of it's examples are with monthly and weekly frequencies. If someone can think of an example where using bysetpos with one of these other frequencies makes sense, let me know.

jkehres · 2023-01-10T22:05:11Z

spec/examples/to_yaml_spec.rb

@@ -78,7 +78,7 @@ module IceCube
    end

    it "should be able to make a round-trip to YAML with .day_of_year" do
-      schedule1 = Schedule.new(Time.now)
+      schedule1 = Schedule.new(Time.zone.now)


Time.zone is another active support extension. The stock Time class in Ruby has no zone method.

jkehres · 2023-01-11T17:50:31Z

I've pushed bysetpos support for weekly frequencies too. I don't think bysetpos makes sense with frequencies of daily, hourly, minutely, or secondly. RFC 5545 makes no mention of them, and indeed all of it's examples are with monthly and weekly frequencies. If someone can think of an example where using bysetpos with one of these other frequencies makes sense, let me know.

I believe BYSETPOS support is still needed for daily, hourly, and minutely frequencies to be compliant with the RFC, which I think should be the goal of this PR. As I mentioned in my comment here, you can see BYSETPOS having an effect for these other frequencies using rrule.js - another library that implements RFC 5545 (itself a port of the python-dateutil library). If ice_cube and these other libraries all properly implement the spec, they should all give the same answer for the same RRULE. We could use that fact to aid in testing this PR to ensure we have a compliant implementation of the RFC. We could us one of these other libraries to generate a more exhaustive set of test inputs and outputs for RRULEs that use BYSETPOS and, thus, increase the number of tests for this new code along with our confidence in it.

Secondly, even though the RFC gives no examples for these other frequencies with BYSETPOS, I think you can derive that they are necessary from the details in the spec.

From the description of BYSETPOS (emphasis mine):

The BYSETPOS rule part specifies a COMMA-separated list of values that corresponds to the nth occurrence within the set of recurrence instances specified by the rule. BYSETPOS operates on a set of recurrence instances in one interval of the recurrence rule.

My understanding of the spec is that "interval" in this context means one unit of the frequency regardless of the INTERVAL rule part so one year for yearly, one month for monthly, etc. If there are multiple recurrences instances within one interval (e.g. year, month, etc.), then BYSETPOS has an effect and selects the nth one. Normally, there is only a single recurrence instance within an interval. The way you get more than one recurrence instance in an interval is by adding another BYxxx rule part.

Again, from the spec (emphasis mine):

BYxxx rule parts modify the recurrence in some manner. BYxxx rule parts for a period of time that is the same or greater than the frequency generally reduce or limit the number of occurrences of the recurrence generated. For example, "FREQ=DAILY;BYMONTH=1" reduces the number of recurrence instances from all days (if BYMONTH rule part is not present) to all days in January. BYxxx rule parts for a period of time less than the frequency generally increase or expand the number of occurrences of the recurrence. For example, "FREQ=YEARLY;BYMONTH=1,2" increases the number of days within the yearly recurrence set from 1 (if BYMONTH rule part is not present) to 2.

Furthermore, this table from the spec shows how each BYxxx rule part interacts with a given frequency and whether it expands or limits the number of recurrences instances:

   +----------+--------+--------+-------+-------+------+-------+------+
   |          |SECONDLY|MINUTELY|HOURLY |DAILY  |WEEKLY|MONTHLY|YEARLY|
   +----------+--------+--------+-------+-------+------+-------+------+
   |BYMONTH   |Limit   |Limit   |Limit  |Limit  |Limit |Limit  |Expand|
   +----------+--------+--------+-------+-------+------+-------+------+
   |BYWEEKNO  |N/A     |N/A     |N/A    |N/A    |N/A   |N/A    |Expand|
   +----------+--------+--------+-------+-------+------+-------+------+
   |BYYEARDAY |Limit   |Limit   |Limit  |N/A    |N/A   |N/A    |Expand|
   +----------+--------+--------+-------+-------+------+-------+------+
   |BYMONTHDAY|Limit   |Limit   |Limit  |Limit  |N/A   |Expand |Expand|
   +----------+--------+--------+-------+-------+------+-------+------+
   |BYDAY     |Limit   |Limit   |Limit  |Limit  |Expand|Note 1 |Note 2|
   +----------+--------+--------+-------+-------+------+-------+------+
   |BYHOUR    |Limit   |Limit   |Limit  |Expand |Expand|Expand |Expand|
   +----------+--------+--------+-------+-------+------+-------+------+
   |BYMINUTE  |Limit   |Limit   |Expand |Expand |Expand|Expand |Expand|
   +----------+--------+--------+-------+-------+------+-------+------+
   |BYSECOND  |Limit   |Expand  |Expand |Expand |Expand|Expand |Expand|
   +----------+--------+--------+-------+-------+------+-------+------+
   |BYSETPOS  |Limit   |Limit   |Limit  |Limit  |Limit |Limit  |Limit |
   +----------+--------+--------+-------+-------+------+-------+------+

For secondly, you can see that no BYxxx rule part will expand the set of recurrence instances so BYSETPOS won't have an effect. However, for minutely, hourly, and daily frequencies you can see that some BYxxx rule parts will expand the set of recurrences, which would allow BYSETPOS to select the nth one in an interval and thus alter the final set of recurrence instances.

jkehres · 2023-01-11T20:41:21Z

spec/examples/by_set_pos_spec.rb

+  describe WeeklyRule, 'BYSETPOS' do
+    it 'should behave correctly' do
+      # Weekly on Monday, Wednesday, and Friday with the week starting on Wednesday, the last day of the set
+      schedule = IceCube::Schedule.from_ical("RRULE:FREQ=WEEKLY;COUNT=4;WKST=WE;BYDAY=MO,WE,FR;BYSETPOS=-1")


For each of the frequencies, it would be nice to have the following test cases:

With a BYxxx that expands the set of recurrence instances...

BYSETPOS with a positive value

BYSETPOS with a negative value

BYSETPOS with multiple positive values

BYSETPOS with multiple negative values

BYSETPOS with multiple values both positive and negative

BYSETPOS with multiple repeated values - spec does not define behaviour; rrule.js does some weird things and outputs the same occurrence multiple times (bug or maybe just undefined behaviour?)

BYSETPOS with a value that matches in some intervals but not others (e.g. selecting the 5th Monday of every month since some months will have only 4 Mondays)

BYSETPOS with a positive value beyond than the number of recurrence instances in any interval (e.g. the 10th Monday of every month); rrule.js returns an empty set of occurrences

BYSETPOS with a negative value bigger than the number of recurrence instances in any set (e.g. the -10th Monday of every month); rrule.js returns a non-empty set of occurrences, which is weird (bug or maybe just undefined behaviour?)

BYSETPOS with each BYxxx that expands the set of recurrence instances for the current frequency

BYSETPOS with BYxxx that limits the set of recurrence instances instead of expanding it

BYSETPOS with no BYxxx - spec says BYSETPOS "MUST only be used in conjunction with another BYxxx rule part" so not sure if this should be an exception or an empty set of occurrences returned; rrule.js does the latter

BYSETPOS with multiple BYxxx rules parts that expand the recurrence instances

BYSETPOS with multiple BYxxx rules parts that both expand and limit the recurrence instances

BYSETPOS with a value outside the allowed range (covered in the from_ical tests)

jkehres · 2023-01-11T20:43:34Z

lib/ice_cube/parsers/ical_parser.rb

@@ -75,7 +75,7 @@ def self.rule_from_ical(ical)
        when "BYYEARDAY"
          validations[:day_of_year] = value.split(",").map(&:to_i)
        when "BYSETPOS"
-          # noop
+          params[:validations][:by_set_pos] = value.split(',').collect(&:to_i)


Perhaps use the style validations[:by_set_pos] to match everything else in this case statement.

Also, existing code uses double quotes instead of single quotes for string in split and collect instead of map. Picky but just for consistency.

jkehres · 2023-01-11T20:46:30Z

lib/ice_cube/time_util.rb

+require 'date'
+require 'time'


Changing the type of quotes seems unnecessary. Double quotes are consistent with the existing style.

jkehres · 2023-01-11T21:56:44Z

lib/ice_cube/validations/weekly_by_set_pos.rb

+          ], step_time
+        )
+        new_schedule = IceCube::Schedule.new(start_of_week_adjusted) do |s|
+          s.add_recurrence_rule(IceCube::Rule.from_hash(rule.to_hash.except(:by_set_pos, :count, :until)))


except is another active support method:

https://github.com/rails/rails/blob/v7.0.4/activesupport/lib/active_support/core_ext/hash/except.rb#L12

jkehres · 2023-01-11T21:58:38Z

lib/ice_cube/validations/monthly_by_set_pos.rb

+
+        # Needs to start on the first day of the month
+        new_schedule = IceCube::Schedule.new(IceCube::TimeUtil.build_in_zone([start_of_month.year, start_of_month.month, start_of_month.day, step_time.hour, step_time.min, step_time.sec], start_of_month)) do |s|
+          s.add_recurrence_rule(IceCube::Rule.from_hash(rule.to_hash.except(:by_set_pos, :count, :until)))


Ditto my comment about except.

jkehres · 2023-01-11T21:58:46Z

lib/ice_cube/validations/yearly_by_set_pos.rb

+
+        # Needs to start on the first day of the year
+        new_schedule = IceCube::Schedule.new(IceCube::TimeUtil.build_in_zone([start_of_year.year, start_of_year.month, start_of_year.day, step_time.hour, step_time.min, step_time.sec], start_of_year)) do |s|
+          s.add_recurrence_rule(IceCube::Rule.from_hash(rule.to_hash.except(:by_set_pos, :count, :until)))


Ditto my comment about except.

jkehres · 2023-01-11T22:19:30Z

Using BYSECOND with MONTHLY does not work. I tried this:

ical = "RRULE:FREQ=MONTHLY;COUNT=4;BYSECOND=1,2,3,4;BYSETPOS=2"
schedule = IceCube::Schedule.from_ical(ical)
schedule.start_time = Time.new(2015, 5, 28, 12, 0, 0)
schedule.occurrences_between(Time.new(2015, 01, 01), Time.new(2017, 01, 01))

and got an empty array. I expected to get:

2015-05-28 12:00:02
2015-06-28 12:00:02
2015-07-28 12:00:02
2015-08-28 12:00:02

I suspect there is an assumption in the code that you will only use BYDAY with MONTHLY and not other BYxxx rule parts.

rgalanakis · 2023-07-19T16:09:47Z

First I want to thank @nehresma @jkehres and others for all the work on this.

I believe BYSETPOS support is still needed for daily, hourly, and minutely frequencies to be compliant with the RFC, which I think should be the goal of this PR.

The current code already doesn't implement the RFC, and it fails to do so silently (just spent over an hour finding the this as the source of a bug). I think partial RFC compliance is better than none. And the users who use daily/hourly/minutely frequencies would continue to see the current unimplemented behavior. I know I wouldn't be alone in appreciating getting this work merged.

pacso · 2023-07-20T08:16:37Z

Thanks for the review @jkehres. Can we get the tests running/passing?

jorgemanrubia · 2024-01-04T16:50:47Z

Thank you so much for your work here. I'd love if we can get this merged. Apple Calendar feeds use BYSETPOS when selecting a day of the month. And there is no direct equivalent for the negative values (starting from the end). So this would be super handy.

pacso · 2024-01-05T00:12:49Z

@jorgemanrubia - Since nothing has moved on this PR for a long time ... it might be easiest if you can fork it, get the tests passing and then we can move forwards? I have struggled for time recently otherwise would have done this myself.

The RRULE parser does not support BYPOS, so instead of 'every 2nd tuesday of the month' you get 'every tuesday on the month'. Pulls in the fork [this PR](ice-cube-ruby/ice_cube#449) comes from for the fix, and adds a test to assert it.

Skulli · 2024-09-11T16:09:58Z

Monthly/Yearly would be more than enough for me.

davidstosik mentioned this pull request Jan 4, 2019

Improvement: rule equivalent to BYSETPOS? #289

Open

davidstosik reviewed Jan 4, 2019

View reviewed changes

k3rni reviewed Jan 4, 2019

View reviewed changes

joshbeckman mentioned this pull request Feb 5, 2019

Add support for BYSETPOS (monthly and yearly frequency) #468

Closed

ovinix reviewed Apr 11, 2019

View reviewed changes

davidstosik mentioned this pull request Apr 6, 2022

Implement BYSETPOS davidstosik/ice_cube#1

Closed

chrisrbnelson mentioned this pull request Nov 23, 2022

Add support for BYSETPOS ignitionapp/ice_cube#1

Closed

Nicolas Marlier and others added 4 commits December 12, 2022 11:15

Support BYSETPOS for MONTHLY AND YEARLY freq

136faf0

Modernize BYSETPOS commit

84120b5

A few small updates to Nicolas Marlier's BYSETPOS support added in PR ice-cube-ruby#349

address the spec DST sensitivity in .to_yaml round trips

115d5a8

update PR from feedback

b3042c6

rebased against master -- its been 4 years

nehresma force-pushed the bysetpos branch from 408e0b0 to b3042c6 Compare December 12, 2022 17:29

jkehres reviewed Dec 21, 2022

View reviewed changes

lib/ice_cube/validations/monthly_by_set_pos.rb Outdated Show resolved Hide resolved

fix interval use with bysetpos

0f5c71a

jkehres reviewed Dec 23, 2022

View reviewed changes

lib/ice_cube/validations/monthly_by_set_pos.rb Outdated Show resolved Hide resolved

jkehres reviewed Dec 23, 2022

View reviewed changes

lib/ice_cube/validations/yearly_by_set_pos.rb Outdated Show resolved Hide resolved

jkehres reviewed Dec 24, 2022

View reviewed changes

lib/ice_cube/validations/monthly_by_set_pos.rb Outdated Show resolved Hide resolved

jkehres reviewed Dec 24, 2022

View reviewed changes

lib/ice_cube/validations/monthly_by_set_pos.rb Outdated Show resolved Hide resolved

jkehres reviewed Dec 24, 2022

View reviewed changes

lib/ice_cube/validations/yearly_by_set_pos.rb Outdated Show resolved Hide resolved

nehresma added 2 commits December 27, 2022 09:27

remove unneeded use of activesupport for date arithmetic

621bf3d

support for bysetpos with freq=weekly

ee3171d

jkehres reviewed Jan 10, 2023

View reviewed changes

jkehres reviewed Jan 11, 2023

View reviewed changes

nehresma added 2 commits January 31, 2023 08:49

support for parsing rrules from ical that are very long and wrap

6a50aad

dont require the wrapped line to be the last the ical string

d7ea51e

jcdeniz mentioned this pull request Feb 23, 2023

Added support for BYSETPOS ignitionapp/ice_cube#2

Merged

rgalanakis mentioned this pull request Jan 7, 2024

Pull in IceCube fork with BYPOS fix webhookdb/webhookdb#745

Closed

Skulli mentioned this pull request Sep 11, 2024

Wrong generation with BYSETPOS and MONTHLY #560

Closed



		new_schedule = IceCube::Schedule.new(TimeUtil.previous_month(step_time)) do \|s\|
		s.add_recurrence_rule IceCube::Rule.from_hash(rule.to_hash.reject{\|k, v\| [:by_set_pos, :count, :until].include? k})



		def build_s(builder)
		builder.piece(:by_set_pos) << by_set_pos

Update to BYSETPOS support #449

Are you sure you want to change the base?

Update to BYSETPOS support #449

Conversation

nehresma commented Jul 30, 2018

nehresma commented Jul 30, 2018

davidstosik commented Jan 4, 2019

davidstosik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nehresma commented Jan 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dimerman commented Mar 22, 2019

nehresma commented Mar 22, 2019

nehresma commented Mar 22, 2019

dimerman commented Mar 23, 2019 • edited Loading

mattbooks commented Mar 28, 2019

mattbooks commented Apr 1, 2019

Choose a reason for hiding this comment

pacso commented Oct 21, 2021

Naren1997 commented Mar 6, 2022 • edited Loading

davidstosik commented Mar 6, 2022

jhubert commented May 13, 2022

dimerman commented May 13, 2022

davidstosik commented May 19, 2022 • edited Loading

nehresma commented Dec 12, 2022

nehresma commented Dec 23, 2022

nehresma commented Dec 27, 2022

Choose a reason for hiding this comment

jkehres commented Jan 11, 2023 • edited Loading

jkehres Jan 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkehres commented Jan 11, 2023

rgalanakis commented Jul 19, 2023

pacso commented Jul 20, 2023

jorgemanrubia commented Jan 4, 2024

pacso commented Jan 5, 2024

Skulli commented Sep 11, 2024

dimerman commented Mar 23, 2019 •

edited

Loading

Naren1997 commented Mar 6, 2022 •

edited

Loading

davidstosik commented May 19, 2022 •

edited

Loading

jkehres commented Jan 11, 2023 •

edited

Loading

jkehres Jan 11, 2023 •

edited

Loading