Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vite and Vitest #1847

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Update Vite and Vitest #1847

wants to merge 9 commits into from

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Jan 30, 2025

Pull Request

What does this PR do?

  • updates Vite and Vitest to latest version
  • changes TypeScript config so that it can handle JSON as well with import assertions
  • changes Vite config so that it can be type checked and compatible with latest Vitest

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 added the dependencies Pull requests that update a dependency file label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (1064d09) to head (c80a133).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
- Coverage   98.84%   98.84%   -0.01%     
==========================================
  Files          17       17              
  Lines        1565     1559       -6     
  Branches      338      338              
==========================================
- Hits         1547     1541       -6     
  Misses         18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flevi29 flevi29 requested a review from Strift January 30, 2025 11:15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this going to affect the build?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.typescriptlang.org/docs/handbook/modules/reference.html#node16-nodenext

node16 and nodenext are currently identical, with the exception that they imply different target option values. If Node.js makes significant changes to its module system in the future, node16 will be frozen while nodenext will be updated to reflect the new behavior.

However our target is set, so it doesn't affect the exception. nodenext is required for importing and resolving JSON with TypeScript. In the future node18 will be available, and we'll switch to that.

@flevi29 flevi29 requested a review from Strift January 31, 2025 10:10
@flevi29 flevi29 added the skip-changelog The PR will not appear in the release changelogs label Feb 1, 2025
@flevi29 flevi29 changed the title Update Vitest Update Vite and Vitest Feb 1, 2025
@flevi29 flevi29 removed the skip-changelog The PR will not appear in the release changelogs label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants