Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vite and Vitest #1847

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+342 −327
Open

Update Vite and Vitest #1847

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cfff563
Update Vitest
flevi29 Jan 30, 2025
31fc1a5
Adjust config
flevi29 Jan 30, 2025
f05fed8
Make sure vite config is type checked
flevi29 Jan 30, 2025
44c7a46
Update Vitest and Vite
flevi29 Jan 30, 2025
109b6c5
Adjust config
flevi29 Jan 30, 2025
c03c86b
Make sure vite config is type checked
flevi29 Jan 30, 2025
089bf78
Merge
flevi29 Feb 1, 2025
d4600ee
Merge main
flevi29 Feb 5, 2025
c80a133
Further update vite and vitest
flevi29 Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@
"devDependencies": {
"@eslint/js": "^9.16.0",
"@types/eslint__js": "^8.42.3",
"@vitest/coverage-v8": "2.0.5",
"@vitest/coverage-v8": "^3.0.4",
"@types/node": "^22.10.1",
"eslint": "^9.16.0",
"eslint-plugin-tsdoc": "^0.4.0",
"@vitest/eslint-plugin": "^1.1.23",
"@vitest/eslint-plugin": "^1.1.25",
"eslint-config-prettier": "^9.1.0",
"typescript": "^5.7.2",
"vite": "^6.0.9",
Expand All @@ -95,7 +95,7 @@
"prettier-plugin-jsdoc": "^1.3.0",
"typedoc": "^0.27.6",
"typescript-eslint": "^8.19.0",
"vitest": "2.0.5"
"vitest": "^3.0.4"
},
"packageManager": "[email protected]"
}
3 changes: 2 additions & 1 deletion tsconfig.json
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this going to affect the build?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.typescriptlang.org/docs/handbook/modules/reference.html#node16-nodenext

node16 and nodenext are currently identical, with the exception that they imply different target option values. If Node.js makes significant changes to its module system in the future, node16 will be frozen while nodenext will be updated to reflect the new behavior.

However our target is set, so it doesn't affect the exception. nodenext is required for importing and resolving JSON with TypeScript. In the future node18 will be available, and we'll switch to that.

Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
"compilerOptions": {
// We don't want to check node_modules
"skipLibCheck": true,
"module": "node16",
"module": "nodenext",
// Node.js 18 supports up to ES2022 according to https://www.npmjs.com/package/@tsconfig/node18
"target": "es2022",
"lib": ["ESNext", "dom"],
"resolveJsonModule": true,
"strict": true,
"verbatimModuleSyntax": true
}
Expand Down
6 changes: 3 additions & 3 deletions vite.config.js → vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ export default defineConfig(({ mode }) => {
},
},
test: {
include: "tests/**/*.test.ts",
exclude: "tests/env/**",
include: ["tests/**/*.test.ts"],
exclude: ["tests/env/**"],
fileParallelism: false,
testTimeout: 100_000, // 100 seconds
coverage: { include: "src/**/*.ts" },
coverage: { include: ["src/**/*.ts"] },
},
};
});
Loading