-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD support #27
AD support #27
Conversation
Merge branch 'master' into AD_0.3 # Conflicts: # .travis.yml # R/dDHMM.R # R/dNmixture.R
@perrydv Just to let you know that all N-mixture models with AD supported are in the Nmixture-AD branch. You can see how to use the code there. Let me know you want me to do anything. |
@perrydv Looks like dNmixture's AD test is failing during a NIMBLE compilation step if you want to take a look. Is this related to Wei's comment about the two different branches? |
@weizhangstats Thanks for the comment. Yes, sorry for not explaining. For the reasons commented in your PR, I wanted to work on the Nmixture AD support a bit more. I wanted to retain a way for non-AD users to get the automatic Nmin and Nmax determination, and I wanted to separate the numerical stability "max_index" from getting baked in arbitrarily on the first call. (It is still baked in, but with a heuristic choice rather than arbitrarily due to parameters involved in the first call). It was easiest for me to consolidate everything in this PR with the other distributions, having drawn on your branch where I could. @dochvam I will look at the test failure. I think you fixed the yaml setup, thanks. The tests run on my machine, so I'm hoping it is some trivial issue to fix. |
I don't know the actions and yaml setup very well. I noticed it was still installing nimble branch ADoak, but at this point it should use the released version of nimble, so I changed that. I also updated some tests. I also realized that the |
Status update: Various details are tweaked and fixed and tests pass on OS X and Windows. So I think it is very nearly ready to go. It would be nice to get linux testing working. And it would be good to have review of code and documentation. |
I'm no longer seeing the Linux tests in the GHA report. |
I do see the GHA checks on ubuntu in the report, looks like they're all passing! |
Oh, I see. There are two separate actions, one for windows and one not, so one needs to toggle between them via links on the upper left, unlike with the GHA for nimble itself. |
Here is the PR with AD support for the nimbleEcology distributions. This includes:
dNmixtureAD_*
nimbleFunctions.dNmixtureAD_*
cases when used not for derivatives)len
parameter from the*_oneObs
distributions.