Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added EventSender to FullNode type #14268

Merged
merged 6 commits into from
Feb 9, 2025

Conversation

PoulavBhowmick03
Copy link
Contributor

Fixes #14097

  • Added event_sender to the FullNode struct (reth/crates/node/builder/src/node.rs).
  • Modified the instantiation of FullNode (reth/crates/node/builder/src/launch/engine.rs) to include event_sender.clone().

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to change this slightly

and move the field to:

pub struct RpcHandle<Node: FullNodeComponents, EthApi: EthApiTypes> {

instead,

for this we also need to add it here

/// Handle to the beacon consensus engine.
pub beacon_engine_handle:
BeaconConsensusEngineHandle<<N::Types as NodeTypesWithEngine>::Engine>,

which then gets passed to:

let RpcHandle { rpc_server_handles, rpc_registry } =
add_ons.launch_add_ons(add_ons_ctx).await?;

and configured to the FullNodeType like:

add_ons_handle: RpcHandle { rpc_server_handles, rpc_registry },

@mattsse mattsse added C-enhancement New feature or request A-sdk Related to reth's use as a library labels Feb 8, 2025
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

this has become more urgent so I applied the remaining changes

@mattsse mattsse added this pull request to the merge queue Feb 9, 2025
Merged via the queue into paradigmxyz:main with commit b48426e Feb 9, 2025
44 checks passed
@PoulavBhowmick03 PoulavBhowmick03 deleted the sealed_header_alias branch February 10, 2025 04:18
18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
Co-authored-by: Roman Krasiuk <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EventSender to FullNode type
3 participants