-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added EventSender to FullNode type #14268
added EventSender to FullNode type #14268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to change this slightly
and move the field to:
reth/crates/node/builder/src/rpc.rs
Line 305 in 44985c3
pub struct RpcHandle<Node: FullNodeComponents, EthApi: EthApiTypes> { |
instead,
for this we also need to add it here
reth/crates/node/api/src/node.rs
Lines 125 to 127 in 44985c3
/// Handle to the beacon consensus engine. | |
pub beacon_engine_handle: | |
BeaconConsensusEngineHandle<<N::Types as NodeTypesWithEngine>::Engine>, |
which then gets passed to:
reth/crates/node/builder/src/launch/engine.rs
Lines 282 to 283 in 44985c3
let RpcHandle { rpc_server_handles, rpc_registry } = | |
add_ons.launch_add_ons(add_ons_ctx).await?; |
and configured to the FullNodeType like:
reth/crates/node/builder/src/launch/engine.rs
Line 406 in 44985c3
add_ons_handle: RpcHandle { rpc_server_handles, rpc_registry }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty!
this has become more urgent so I applied the remaining changes
Co-authored-by: Roman Krasiuk <[email protected]> Co-authored-by: Matthias Seitz <[email protected]>
Fixes #14097
event_sender
to theFullNode
struct (reth/crates/node/builder/src/node.rs
).FullNode
(reth/crates/node/builder/src/launch/engine.rs
) to includeevent_sender.clone()
.