Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix clippy errors on main #1019

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dsherret
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@84cf467). Learn more about missing BASE report.

Files with missing lines Patch % Lines
url/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage        ?   80.40%           
=======================================
  Files           ?       24           
  Lines           ?     4225           
  Branches        ?        0           
=======================================
  Hits            ?     3397           
  Misses          ?      828           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure how to supress this memory leak sanitizer. Looks like a once_cell within std:

=================================================================
==3816==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 168 byte(s) in 1 object(s) allocated from:
    #0 0x000105e35490 in malloc+0x6c (librustc-nightly_rt.asan.dylib:arm64+0x51490)
    #1 0x00018d67e450  (<unknown module>)
    #2 0x134600018da02028  (<unknown module>)
    #3 0x3126000104c0da20  (<unknown module>)
    #4 0x000104b9e404 in core::ops::function::FnOnce::call_once::hf1d45f6b53ec7f8d+0x18 (wpt-8fafb2b4a9e64f2a:arm64+0x10028a404)
    #5 0x000104bf6de8 in std::thread::local::LocalKey$LT$T$GT$::initialize_with::h66b72d914f04e3b8+0x1c0 (wpt-8fafb2b4a9e64f2a:arm64+0x1002e2de8)
    #6 0x000104bf73a0 in std::thread::local::LocalKey$LT$core..cell..Cell$LT$T$GT$$GT$::set::hf1dfde8269097b58+0x40 (wpt-8fafb2b4a9e64f2a:arm64+0x1002e33a0)
    #7 0x000104c04a5c in std::sys::pal::unix::stack_overflow::imp::init::h4a1d0202557b6f10+0x20c (wpt-8fafb2b4a9e64f2a:arm64+0x1002f0a5c)
    #8 0x000104d0d1c4 in std::sys::pal::unix::init::h24e5cfc0c33228ae+0x30 (wpt-8fafb2b4a9e64f2a:arm64+0x1003f91c4)
    #9 0x000104cc8248 in std::rt::init::h233c8ef7bd608d1f+0x1c (wpt-8fafb2b4a9e64f2a:arm64+0x1003b4248)
    #10 0x000104cc8710 in std::rt::lang_start_internal::_$u7b$$u7b$closure$u7d$$u7d$::hbedd142564420d2e+0x1c0 (wpt-8fafb2b4a9e64f2a:arm64+0x1003b4710)
    #11 0x000104cb6484 in std::panicking::try::do_call::heb428ba1fd90177b+0x13c (wpt-8fafb2b4a9e64f2a:arm64+0x1003a2484)
    #12 0x000104cba79c in __rust_try+0x1c (wpt-8fafb2b4a9e64f2a:arm64+0x1003a679c)
    #13 0x000104cb6064 in std::panicking::try::h6ae34f3c5574956a+0x16c (wpt-8fafb2b4a9e64f2a:arm64+0x1003a2064)
    #14 0x000104b923dc in std::panic::catch_unwind::h9cf7e9243c22ba4a+0x8 (wpt-8fafb2b4a9e64f2a:arm64+0x10027e3dc)
    #15 0x000104cc8480 in std::rt::lang_start_internal::h53d56cb1a8920960+0x1a0 (wpt-8fafb2b4a9e64f2a:arm64+0x1003b4480)
    #16 0x00010491bfe0 in std::rt::lang_start::h924f0470c77c9780 rt.rs:198
    #17 0x0001049455a8 in main+0x20 (wpt-8fafb2b4a9e64f2a:arm64+0x1000315a8)
    #18 0x00018d66f150  (<unknown module>)
    #19 0x21157ffffffffffc  (<unknown module>)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants