Create Completed Monthly Return Logs page #1484
Draft
+1,277
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prettified! |
We create an initial route, controller and service, which work together to pull the data via a legacy API request. This is then sent to an initial page which simply dumps the data to the page.
We've found that the purpose text we retrieve is all-caps and we want it to be in title case. However `BasePresenter.titleCase()` does not handle this -- it capitalises the first letter of each word while leaving the rest of the word as-is, effectively returning the same all-caps string. Up until now this behaviour was neither desired nor undesired; we simply didn't have a need to convert an all-caps string to title case. Now that we do, we amend `BasePresenter.titleCase()` to first convert the string to lower case before capitalising the first letter of each word, thus forcing all-caps text into title case.
This follows our convention (followed most of the time!) of starting with the resource name i.e. what we called the model! Then, the main route (show all records) is `index.*.js`/`index.njk` and for an individual it is `view.*.js`/`view.njk` Co-authored-by: Stuart Adair <[email protected]>
This gives an initial starting example for how we can grab the data we need for the view without needing to make a request to the legacy service or parse its response.
Cruikshanks
force-pushed
the
new-view-completed-monthly-return-logs-page
branch
from
5ef0e98 to
03ac67b
Compare
Co-authored-by: Stuart Adair <[email protected]>
We are moving to a pattern of setting `pageTitle` in presenters and `activeNavBar` in services. This commit changes our code to reflect this.
`ViewReturnLogPresenter` brings in `formatStartReading` which no longer exists, so we remove it.
Cruikshanks
added a commit
that referenced
this pull request
Jan 15, 2025
https://eaflood.atlassian.net/browse/WATER-4745 > See [](#1484) The following changes are included - switch to existing status macro and remove duplicate - set correct status in presenter - update versions design (add 'Version x' as a line and prefix with 'Viewing ' for selected version) - add received date to the metadata - update all return log links to go to view page - update Edit return to be Edit or Submit return (depending on return log status) - update page to handle viewing _any_ return log, including 'due' and 'received' which have no submission data
Cruikshanks
added a commit
that referenced
this pull request
Jan 15, 2025
https://eaflood.atlassian.net/browse/WATER-4745 > See [Create Completed Monthly Return Logs page](#1484) > Will not work until `main` is merged into `new-view-completed-monthly-return-logs-page` The following changes are included - switch to existing status macro and remove duplicate - set correct status in presenter - update versions design (add 'Version x' as a line and prefix with 'Viewing ' for selected version) - add received date to the metadata - update all return log links to go to view page - update Edit return to be Edit or Submit return (depending on return log status) - update page to handle viewing _any_ return log, including 'due' and 'received' which have no submission data
Cruikshanks
added a commit
that referenced
this pull request
Jan 16, 2025
https://eaflood.atlassian.net/browse/WATER-4745 > See [Create Completed Monthly Return Logs page](#1484) > Will not work until `main` is merged into `new-view-completed-monthly-return-logs-page` The following changes are included - switch to existing status macro and remove duplicate - set correct status in presenter - update versions design (add 'Version x' as a line and prefix with 'Viewing ' for selected version) - add received date to the metadata - update all return log links to go to view page - update Edit return to be Edit or Submit return (depending on return log status) - update page to handle viewing _any_ return log, including 'due' and 'received' which have no submission data
https://eaflood.atlassian.net/browse/WATER-4745 > See [Create Completed Monthly Return Logs page](#1484) The following changes are included - switch to existing status macro and remove duplicate - set correct status in presenter - update versions design (add 'Version x' as a line and prefix with 'Viewing ' for selected version) - add received date to the metadata - update all return log links to go to view page - update Edit return to be Edit or Submit return (depending on return log status) - update page to handle viewing _any_ return log, including 'due' and 'received' which have no submission data
We start by renaming the presenter's test file and pointing at the now-renamed presenter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4745
https://wrls-prototype.herokuapp.com/sandbox/licence/returns-current/return