-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logstash-keystore to accept spaces in values when added via stdin #17039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
robbavey
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@logstashmachine backport 8.18 |
5 tasks
kaisecheng
added a commit
that referenced
this pull request
Feb 7, 2025
…#17039) (#17040) This commit preserves spaces in values, ensuring that multi-word strings are stored as intended. Prior to this change, `logstash-keystore` incorrectly handled values containing spaces, causing only the first word to be stored. (cherry picked from commit 5573b5a) Co-authored-by: kaisecheng <[email protected]>
@logstashmachine backport 8.17 |
@logstashmachine backport 9.0 |
kaisecheng
added a commit
that referenced
this pull request
Feb 7, 2025
…#17039) (#17041) This commit preserves spaces in values, ensuring that multi-word strings are stored as intended. Prior to this change, `logstash-keystore` incorrectly handled values containing spaces, causing only the first word to be stored. (cherry picked from commit 5573b5a) Co-authored-by: kaisecheng <[email protected]>
5 tasks
kaisecheng
added a commit
that referenced
this pull request
Feb 7, 2025
…#17039) (#17042) This commit preserves spaces in values, ensuring that multi-word strings are stored as intended. Prior to this change, `logstash-keystore` incorrectly handled values containing spaces, causing only the first word to be stored. (cherry picked from commit 5573b5a) Co-authored-by: kaisecheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Fix logstash-keystore to accept spaces in values when added via stdin
What does this PR do?
logstash-keystore
incorrectly handled values containing spaces, causing only the first word to be stored.For example, a value like "Hello, world!" was split, resulting in "Hello," as the stored value instead of the full string.
This commit preserves spaces in values, ensuring that multi-word strings are stored as intended.
Why is it important/What is the impact to the user?
This issue mainly affected ECK users who followed best practices for managing secure settings, leading to incorrect value assignments.
Users who use stdin to add value are impacted as well. For example,
echo "somevalue" | bin/logstash-keystore add hello
Checklist
Author's Checklist
How to test this PR locally
it should print "hello world"
Related issues
Use cases
Screenshots
Logs